Add support for PostGIS #24053
Open
Add support for PostGIS #24053
+301
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having trouble getting the tests to pass. TestPostgreSqlPlugin fails because the geometry type is not injected into PostgreSqlClient. I couldn't figure out how to fixed that. |
umartin
force-pushed
the
geometry_postgis
branch
from
403d48d
to
c24058b
Compare
|
It looks like the TestingConnectorContext used in TestPostgreSqlPlugin doesn't have the geometry type in the type manager. TestingConnectorContext is a final class so I can't extend it. Should I just create a TestingPostgreSqlConnectorContext with an extended type manager? |
umartin
force-pushed
the
geometry_postgis
branch
from
c24058b
to
2b97da8
Compare
umartin
force-pushed
the
geometry_postgis
branch
from
2b97da8
to
40ed422
Compare
|
@ebyhr I think this PR is ready for review. All checks pass. I've also built and tested the trino docker image with postgis manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for geometry type mapping in the PostgreSQL connector.
Additional context and related issues
Issue: #5580
There is an old, inactive PR at #9951
My take is slightly different when it comes to reading PostGIS geometries. The previous attempt rewrote the query and wrapped geometry columns in ST_GeomAsWKB to convert them to a Well Known Binary format. I'm using the native format which is hex encoded EWKB.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: Add support for geometry type mapping in the PostgreSQL connector