-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the readme #23
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,9 +125,7 @@ abstract class GenericStringUtil { | |
} | ||
|
||
private val simpleString: P[String] = | ||
P.charWhere(c => c >= ' ' && c != '"' && c != '\\') | ||
.rep | ||
.string | ||
P.charsWhile(c => c >= ' ' && c != '"' && c != '\\') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Stray commit, but I don't think harmful. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, I kind of snuck this in... :) I noticed Erik has reimplemented charsWhile and I wanted to use it in the example. |
||
|
||
def escapedString(q: Char): P1[String] = { | ||
val end: P1[Unit] = P.char(q) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more code we put into this, the more risk it rots. Getting this verified with mdoc would be a nice part of #7. But 👍 to getting this out there now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally agree: #24