-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add material theme to paradox #98
Conversation
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 5 5
Lines 676 676
Branches 57 57
=======================================
Hits 652 652
Misses 24 24 Continue to review full report at Codecov.
|
seems pretty nice to me. Seems pretty easy to merge and change later. That said, is the site being published? |
Hi @johnynek, sorry for the late reply! It's not being pushed; I intend to make it so. Just wanted to see if this would be nice to have first. 😄 I'll update this later. Thanks! |
Hi @johnynek took me longer than expected to follow up on this. Added a step to CI to make the site automatically published on release. |
addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1") | ||
addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These allows us to easily do adhoc site pushes through docs/ghpagesPushSite
This is great! I personally think the win of using an all scala/sbt solution is worth it in terms of simplicity of the CI and build. |
🎉 We use this on http4s-jdk-http-client, and I would love to see it spread. The multi-version support is lacking, but other than that, it's a solid tool and an attractive, functional theme. And no futzing with Jekyll or Hugo is a big win. |
Related to #7 |
I know #39 is still being worked on but since we have already paradox I thought we could put it to some use in the meantime? wdyt is it worth it?