Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add material theme to paradox #98

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Add material theme to paradox #98

merged 3 commits into from
Dec 7, 2020

Conversation

regadas
Copy link
Collaborator

@regadas regadas commented Nov 27, 2020

I know #39 is still being worked on but since we have already paradox I thought we could put it to some use in the meantime? wdyt is it worth it?

page

@codecov-io
Copy link

codecov-io commented Nov 27, 2020

Codecov Report

Merging #98 (1500f47) into main (848b05d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files           5        5           
  Lines         676      676           
  Branches       57       57           
=======================================
  Hits          652      652           
  Misses         24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848b05d...1500f47. Read the comment docs.

@johnynek
Copy link
Collaborator

seems pretty nice to me. Seems pretty easy to merge and change later.

That said, is the site being published?

@regadas
Copy link
Collaborator Author

regadas commented Dec 4, 2020

Hi @johnynek, sorry for the late reply! It's not being pushed; I intend to make it so. Just wanted to see if this would be nice to have first. 😄

I'll update this later. Thanks!

@regadas regadas marked this pull request as ready for review December 7, 2020 16:14
@regadas
Copy link
Collaborator Author

regadas commented Dec 7, 2020

Hi @johnynek took me longer than expected to follow up on this. Added a step to CI to make the site automatically published on release.

Comment on lines +13 to +14
addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These allows us to easily do adhoc site pushes through docs/ghpagesPushSite

@johnynek
Copy link
Collaborator

johnynek commented Dec 7, 2020

This is great! I personally think the win of using an all scala/sbt solution is worth it in terms of simplicity of the CI and build.

@rossabaker
Copy link
Member

🎉 We use this on http4s-jdk-http-client, and I would love to see it spread. The multi-version support is lacking, but other than that, it's a solid tool and an attractive, functional theme. And no futzing with Jekyll or Hugo is a big win.

@johnynek johnynek merged commit b456c60 into typelevel:main Dec 7, 2020
@johnynek
Copy link
Collaborator

Related to #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants