-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve API around transforming loggers #854
base: main
Are you sure you want to change the base?
Improve API around transforming loggers #854
Conversation
I have imagined something like this, but it does result in a switch statement on every logging operation, at least for the common slf4j backend. Does anybody have an inkling of the performance impact of this? |
…n-peschke/log4cats into explore-logger-transformer
I'm not sure, though I'm optimistic. Since there's already at least 1-2 conditionals per logging operation (checking the log level, and if to restore or clear the MDC, in addition to whatever goes on inside the MDC and Log4J) my gut-check is it won't be enough to move the needle 🤞🏻 I don't think we have |
Yeah, any performance metrics here risk falling into the same trap we see in the |
Inspired by the tedium of #835