fix(codemod): configPath maybe .umirc.ts or .umirc.js #11936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schifred
commented
Dec 7, 2023
schifred
commented
- 问题：当应用使用 .umirc.ts 作为配置文件，执行 pnpm dlx @umijs/codemod@latest 命令报配置文件未找到错误
- 处理：prepare 过程获知配置文件路径，通过 context 传入 ConfigRunner
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
fz6m
reviewed
Dec 12, 2023
| @@ -123,17 +121,12 @@ export class Runner { | |||
| setKeys['layout.locale'] = false; | |||
| } | |||
|
|
|||
| const configFile = join(this.cwd, 'config/config.ts'); | |||
There was a problem hiding this comment.
在这里改的话，需要使用 tryPaths 或者 prepare 中的逻辑推断下用户实际使用的配置文件是否是 config/config.ts, config/config.js 还是 .umirc.ts, .umirc.js，而这个逻辑在前置流程里 prepare 已经做了，所以通过 context 传递可以避免重复开发
There was a problem hiding this comment.
这里可以这样获得最少的代码更改吧：
const configFile = this.context.configPath;| @@ -75,6 +75,7 @@ export async function prepare(opts: { cwd: string; pattern: any; args?: any }) { | |||
|
|
|||
| return { | |||
| config, | |||
| configPath: mainConfigFile, | |||
There was a problem hiding this comment.
建议这个命名最好叫 mainConfigPath 或者 mainConfigFile ，因为 configPath 指代哪个 config 文件不明确。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.