Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local build/dev tests for examples #21

Merged
merged 45 commits into from
Nov 12, 2024
Merged

Add local build/dev tests for examples #21

merged 45 commits into from
Nov 12, 2024

Conversation

CahidArda
Copy link
Collaborator

@CahidArda CahidArda commented Nov 8, 2024

Added CI tests which do the following:

  • run the untittests
  • build the workflow-js project
  • install the local build in all examples and run npm run build and npm run dev
  • make a ci release
  • run workflows with the ci release in examples/ci, examples/cloudflare-workers-hono, examples/nextjs-12 and examples/nextjs-pages.

There are also a number of fixes:

  • serve for nextjs pages router doesn't stringify all bodies anymore. it returns strings as they are, undefined as it is and stringifies the rest
  • triggerFirstInvocation uses publish instead of publishJSON so that a content type header can be set (publishJSON sets the content type to application/json)
  • fixes failure callback retry and forwards user headers to failure callback

@CahidArda CahidArda force-pushed the local-example-ci branch 4 times, most recently from 9d91801 to e9dbb5d Compare November 8, 2024 12:19
@CahidArda
Copy link
Collaborator Author

reproduced the crypto is not defined error in the last tests

@CahidArda CahidArda force-pushed the local-example-ci branch 2 times, most recently from b0fefce to 57cf6d7 Compare November 10, 2024 09:40
@CahidArda CahidArda force-pushed the local-example-ci branch 2 times, most recently from 8115f6a to 85f0d69 Compare November 12, 2024 14:28
@CahidArda
Copy link
Collaborator Author

as we discussed the changes in this PR with dx and workflow team, I am merging the PR.

@CahidArda CahidArda merged commit d4248b2 into main Nov 12, 2024
17 checks passed
@CahidArda CahidArda deleted the local-example-ci branch November 12, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant