-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local build/dev tests for examples #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CahidArda
force-pushed
the
local-example-ci
branch
from
November 8, 2024 11:24
256f13c
to
51477fc
Compare
CahidArda
force-pushed
the
local-example-ci
branch
from
November 8, 2024 11:31
5f84c54
to
8c7c5be
Compare
CahidArda
force-pushed
the
local-example-ci
branch
4 times, most recently
from
November 8, 2024 12:19
9d91801
to
e9dbb5d
Compare
CahidArda
force-pushed
the
local-example-ci
branch
from
November 8, 2024 12:29
e9dbb5d
to
8e44711
Compare
reproduced the |
CahidArda
force-pushed
the
local-example-ci
branch
from
November 8, 2024 22:17
7367e29
to
255591d
Compare
CahidArda
force-pushed
the
local-example-ci
branch
2 times, most recently
from
November 10, 2024 09:40
b0fefce
to
57cf6d7
Compare
CahidArda
force-pushed
the
local-example-ci
branch
from
November 10, 2024 09:43
57cf6d7
to
2431376
Compare
also fixes how the body is used in nextjs-pages is used
CahidArda
force-pushed
the
local-example-ci
branch
from
November 11, 2024 21:41
0b9196e
to
6a9498e
Compare
CahidArda
force-pushed
the
local-example-ci
branch
from
November 11, 2024 21:53
21bc6d0
to
11f0cca
Compare
CahidArda
force-pushed
the
local-example-ci
branch
from
November 11, 2024 23:34
217e04b
to
b87c498
Compare
CahidArda
force-pushed
the
local-example-ci
branch
2 times, most recently
from
November 12, 2024 14:28
8115f6a
to
85f0d69
Compare
CahidArda
force-pushed
the
local-example-ci
branch
from
November 12, 2024 14:39
85f0d69
to
b6eb97b
Compare
as we discussed the changes in this PR with dx and workflow team, I am merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CI tests which do the following:
npm run build
andnpm run dev
examples/ci
,examples/cloudflare-workers-hono
,examples/nextjs-12
andexamples/nextjs-pages
.There are also a number of fixes: