Make logged metadata a little more readable #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore by descending recursively into dictionary and array metadata.
gwynne
added
the
semver-patch
dimitribouniol
approved these changes
May 29, 2024
Comment on lines
+83
to
+86
| var swiftSettings: [SwiftSetting] { [ | ||
| .enableUpcomingFeature("ForwardTrailingClosures"), | ||
| .enableUpcomingFeature("ConciseMagicFile"), | ||
| ] } |
There was a problem hiding this comment.
Mostly curiosity, is there a reason we are opting for a computed property here rather than a constant?
There was a problem hiding this comment.
Because it lets me put the settings at the bottom of the file instead of the top (and I must admit it was @MahdiBM who came up with that).
…pite changes to the file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
+ Coverage 48.07% 48.35% +0.28%
==========================================
Files 45 45
Lines 1762 1764 +2
==========================================
+ Hits 847 853 +6
+ Misses 915 911 -4
|
weissi
reviewed
May 30, 2024
0xTim
approved these changes
May 30, 2024
| @@ -327,11 +327,22 @@ public struct TimestampFragment<S: TimestampSource>: LoggerFragment { | |||
| } | |||
| } | |||
|
|
|||
| private extension Logger.MetadataValue { | |||
| var descriptionWithoutExcessQuotes: String { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.14.3
We now explicitly suppress excess
"characters recursively in logger metadata.Also bumps the package to a minimum of Swift 5.8 and fixes some warnings.