DATA-3338-fix-stability-of-vision-capture-all-from-camera #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
nicksanford
commented
Oct 31, 2024
data/collector.go
Outdated
Comment on lines
415
to
428
| // // We special-case the GetReadingsResponse because it already contains | ||
| // // structpb.Values in it, and the StructToStructPb logic does not handle | ||
| // // that cleanly. | ||
| // topLevelMap := make(map[string]*structpb.Value) | ||
| // topLevelMap["readings"] = structpb.NewStructValue( | ||
| // &structpb.Struct{Fields: reading.(pb.GetReadingsResponse).Readings}, | ||
| // ) | ||
| // pbReading = &structpb.Struct{Fields: topLevelMap} | ||
| // } else { | ||
| // pbReading, err = protoutils.StructToStructPbIgnoreOmitEmpty(reading) | ||
| // if err != nil { | ||
| // c.captureErrors <- errors.Wrap(err, "error while converting reading to structpb.Struct") | ||
| // return | ||
| // } |
There was a problem hiding this comment.
TODO: Update collectors that return GetReadings to format their response appropriately
nicksanford
force-pushed
the
DATA-3338-fix-stability-of-vision-capture-all-from-camera
branch
from
4284ac7
to
1d17e45
Compare
viambot
added
safe to test
nicksanford
force-pushed
the
DATA-3338-fix-stability-of-vision-capture-all-from-camera
branch
from
ab96093
to
90109b1
Compare
viambot
added
safe to test
nicksanford
force-pushed
the
DATA-3338-fix-stability-of-vision-capture-all-from-camera
branch
from
90109b1
to
2ccf1f4
Compare
viambot
added
safe to test
|
moved here: #4557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.