Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use select fields where it makes sense #4

Open
wants to merge 9 commits into
base: craft-4
Choose a base branch
from

Conversation

joshuapease
Copy link
Contributor

@joshuapease joshuapease commented May 17, 2024

I switched the majority our site properties over to Select and MultiSelect properties.

This makes it so we can more easily filter:

  • environment
  • plugin installed
  • plugin version
  • php version
  • craft version
  • etc.

CleanShot 2024-05-20 at 11 35 10

@joshuapease joshuapease changed the title Use select fields Use select fields where it makes sense May 20, 2024
Comment on lines +65 to +70
self::PROPERTY_PLUGINS => [
'class' => MultiSelectDb::class,
],
self::PROPERTY_PLUGIN_VERSIONS => [
'class' => MultiSelectDb::class,
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a plugin & plugin versions column.

The plugin column will let you filter by what plugins are installed by site.

But if you ever need to check for specific versions, you can also choose that.

I wish there was a way to do version greater than / less than queries. But I can't think of anything in Notion that would provide that.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How sensitive is this to manipulations to the table? It might be possible to use a formula in a manually-created column but would that confuse the plugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom columns seem to work fine. As long as their names don't conflict with what's in this list.

Comment on lines +65 to +70
self::PROPERTY_PLUGINS => [
'class' => MultiSelectDb::class,
],
self::PROPERTY_PLUGIN_VERSIONS => [
'class' => MultiSelectDb::class,
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How sensitive is this to manipulations to the table? It might be possible to use a formula in a manually-created column but would that confuse the plugin?

Copy link

@maxfenton maxfenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little over my head, so 👍 since everyone else approved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants