Multi-metrics throttler: post v21 deprecations and changes #16915
+215
−831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
…mes) Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…expiration duration Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
shlomi-noach
added
Type: Internal Cleanup
Type: Enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16915 +/- ##
==========================================
- Coverage 67.40% 67.39% -0.02%
==========================================
Files 1570 1570
Lines 252903 252834 -69
==========================================
- Hits 170460 170386 -74
- Misses 82443 82448 +5 ☔ View full report in Codecov by Sentry. |
…sociated implementation Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
requested review from
deepthi,
harshit-gangal,
mattlord and
ajm188
as code owners
shlomi-noach
requested review from
GuptaManan100,
rohit-nayak-ps,
systay,
timvaillancourt,
frouioui and
notfelineit
as code owners
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
mattlord
approved these changes
Nov 13, 2024
| @@ -534,11 +528,11 @@ func WaitForValidData(t *testing.T, tablet *cluster.Vttablet, timeout time.Durat | |||
|
|
|||
| for { | |||
| checkResp, checkErr := http.Get(checkURL) | |||
| if checkErr != nil { | |||
| if checkErr == nil { | |||
There was a problem hiding this comment.
We don't want to have a require.NoError(t, checkErr) here before the defer, getting rid of the conditional check? Same below.
There was a problem hiding this comment.
Not in this case, because this is a wait-for function, and I'm OK ignoring the error as long as the function eventually succeeds within the given timeout. So I don't care that there could be multiple errors, and I don't want to report the test as failed.
| @@ -831,8 +829,7 @@ enum CheckThrottlerResponseCode { | |||
| } | |||
|
|
|||
| message CheckThrottlerResponse { | |||
| // StatusCode is HTTP compliant response code (e.g. 200 for OK) | |||
| int32 status_code = 1; | |||
| reserved 1; // was `status_code`, HTTP compliant, deprecated | |||
There was a problem hiding this comment.
Do we care about reserving the name too? I'm not sure, just asking. We can always do that later since your comment clearly indicates what the name was. It's also fine to eventually reuse field names, as long the json/text encodings are still usable and sensible.
There was a problem hiding this comment.
Added reserved names.
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multi metrics throttler was introduced in v21 and was backwards compatible with the v20 single-metric throttler. Compatibility included gRPC, command line flags, etc.
Starting v22, we remove single-metric throttler compatibility. This PR implements various topics seen in:
Changes in this PR:
MultiMetricsEnabledand its usage. It is assumed to be true in v22.--check-as-check-selfand--cehck-as-check-shardcommand line flags and all related implementation.StatusCodeusage.Related Issue(s)
Checklist
Deployment Notes