-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqltypes: add ToTime conversion funcs #17178
base: main
Are you sure you want to change the base?
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
764608c
to
a8b20e9
Compare
there are already conversions for other native types, but datetime conversions were only available in the vitessdriver. This moves that implementation into sqltypes, so it can be more easily accessed elsewhere. Signed-off-by: Derek Perkins <[email protected]>
a8b20e9
to
fb6115e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17178 +/- ##
==========================================
- Coverage 67.33% 67.31% -0.03%
==========================================
Files 1569 1569
Lines 252244 252487 +243
==========================================
+ Hits 169858 169961 +103
- Misses 82386 82526 +140 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why not!
there are already conversions for other native types, but datetime conversions were only available in the vitessdriver. This moves that implementation into sqltypes, so it can be more easily accessed elsewhere. I'm specifically interested in using this with VStream.
The actual implementation was done by @vmg in the driver in 2017, so this just moves it into the sqltypes package, adding a similar
ToTime
method onValue
Checklist