-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve VTOrc config handling to support dynamic variables #17218
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Manan Gupta <[email protected]>
…nce poll seconds Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…o viper Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17218 +/- ##
==========================================
+ Coverage 67.34% 67.41% +0.07%
==========================================
Files 1570 1570
Lines 252734 252867 +133
==========================================
+ Hits 170204 170471 +267
+ Misses 82530 82396 -134 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
viperutil.Options[time.Duration]{ | ||
FlagName: "instance-poll-time", | ||
Default: 5 * time.Second, | ||
Dynamic: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makrs the field dynamic
Description
This PR changes how config files are handled in VTOrc, moving them to use viper instead of the custom solution previously employed. This change allows the following parameters to be dynamically loaded -
InstancePollTime
PreventCrossCellFailover
SnapshotTopologyInterval
ReasonableReplicationLag
AuditToBackend
AuditToSyslog
AuditPurgeDuration
WaitReplicasTimeout
TolerableReplicationLag
TopoInformationRefreshDuration
RecoveryPollDuration
Related Issue(s)
Checklist
Deployment Notes