Add Event and minimal EventTarget #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on feedback from @Arshia001 on this one |
|
Hey @MasatoDev, thank you for your contribution! Currently, it is impossible to define global objects in JS/TS. However, I think it would be beneficial to add that in, so I'll create an issue for it and move this to the global scope once that's implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Thank you for your confirmation.
I implemented
EventandEventTargetthat are related to #9 without detailed dispatching logic.Description
This PR is regarded to bellow spec.
https://dom.spec.whatwg.org/#event
https://dom.spec.whatwg.org/#eventtarget
I referred to the following code.
https://github.com/denoland/deno/blob/main/ext/web/02_event.js
Scope
out-of-scop items
touchstart,touchmove, and so on.Outstanding issue
Currently, I need
import, but I think Event and EventTarget is Global Scope, so which file should I add and implement?Implementation for window and DOM element events is omitted. Please let me know if there is a problem.
I think there is a discussion about whether to include primordials, but I didn't mention it.
Test