Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] testdriver bidi documentation #49098

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[doc] testdriver bidi documentation #49098

merged 1 commit into from
Nov 15, 2024
+114 −24

Conversation

sadym-chromium
Copy link
Contributor

  • Extend testdriver documentation with BiDi section.
  • Improve jsdoc.

@sadym-chromium sadym-chromium requested a review from a team as a code owner November 11, 2024 10:34
OrKoN
OrKoN approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but let's wait for other reviewers and until the RFC to opt-in into WebDriver BiDi lands). We also need to mention that the metadata attribute will be required.

@sadym-chromium
Copy link
Contributor Author

LGTM (but let's wait for other reviewers and until the RFC to opt-in into WebDriver BiDi lands). We also need to mention that the metadata attribute will be required.

This PR is independent from the metadata, so I guess it makes sense even without waiting for that one.

@sadym-chromium
Copy link
Contributor Author

@web-platform-tests/wpt-core-team please take a look.

@sadym-chromium
[doc] testdriver bidi documentation
39b08f6 
* Extend testdriver documentation with **BiDi** section.
* Improve jsdoc for bidi methods.
past
past approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@past past left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@past
Copy link
Member

past commented Nov 15, 2024

The macOS cookie infra test failure seems unrelated. Merging.

@past past merged commit 8bfc4c9 into master Nov 15, 2024
14 of 16 checks passed
@past past deleted the sadym/testdriver-bidi-doc branch November 15, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

@past past past approved these changes

@jgraham jgraham Awaiting requested review from jgraham

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

Assignees

@OrKoN OrKoN

Labels
docs infra testdriver.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sadym-chromium @past @OrKoN @wpt-pr-bot