Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB Backups #1322

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

MongoDB Backups #1322

wants to merge 8 commits into from

Conversation

ikreymer
Copy link
Member

Adds a CronJob which can be enabled via values, using one of the defined storages.
Backups run daily (by default) and store output of mongodump ... --archive to a timestamped file.

@ikreymer ikreymer requested a review from tw4l October 28, 2023 18:11
@ikreymer ikreymer marked this pull request as ready for review October 28, 2023 18:11
# daily under /db-backups
db_backup:
#storage: "default"
#schedule: "26 0 * * *"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting choice of time but why not :)

@tw4l
Copy link
Member

tw4l commented Nov 1, 2023

Should figure out encryption prior to merging/deploying this, so that we don't have an unencrypted copy of our database in an S3 bucket.

Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to Request changes until we figure out encryption

@ikreymer
Copy link
Member Author

ikreymer commented Jul 3, 2024

Probably the best option here is to make this optional by requiring the dump to be encrypted with openssl, by providing an optional private key for encryption.

db_backup:
   encryption_key: ...

or, can also provide the name of designated secret that can be managed externally (but requires more setup).

@ikreymer ikreymer marked this pull request as draft July 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants