Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Localize dates, bytes, and numbers #2146

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Nov 12, 2024

Resolves #2143

Changes

  • Defaults to user's browser language preference when displaying dates, bytes, and numbers (with caveats.) This fixes an issue where numbers were always formatted in English.
  • Shows user's browser language preferences in language dropdown
  • Fixes timezone not displayed in archived item detail start and finish times

Manual testing

Tested with Firefox and Chrome

  1. Set language preference in browser of choice
  2. Log in
  3. Verify dates, bytes, and numbers are displayed correctly in chosen language
  4. Go to Account Settings
  5. Change language preference to a language that displays numbers differently
  6. Go back to org dashboard. Verify date/byte/numbers are displayed correctly

Screenshots

Page Image/video
Account Settings Screenshot 2024-11-12 at 3 22 51 PM
Collections (Browser language set to Korean, no app language set)
Screenshot 2024-11-12 at 3 22 07 PM
Archived Item Detail Screenshot 2024-11-12 at 3 44 13 PM

@SuaYoo SuaYoo marked this pull request as ready for review November 12, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[L10N]: Numbers and dates always formatted in English
1 participant