-
-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: demonstrate callstack in extended client action #2680
base: main
Are you sure you want to change the base?
Conversation
|
@holic is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
'estimateGas:first', | ||
'estimateGas:base', | ||
'getChainId:base', | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the functionality I was trying to understand, where I hoped that this would look more like
[
'estimateGas:second',
'estimateGas:first',
'estimateGas:base',
'getChainId:second',
'getChainId:first',
'getChainId:base',
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could consider binding them (in Viem) to behave like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure of the consequences of that. Would that be a breaking change because it would change the behavior of the entire callstack of extended clients?
I was thinking of writing a separate "compose" decorator wrapper that could handle this.
b56e162
to
ad2831b
Compare
Continued from #2675
PR-Codex overview
The focus of this PR is to refactor and extend action composition in the
createClient
module.Detailed summary
Client
createClient
getChainId
andestimateGas