-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass in Content-Encoding to resource-timing #1742
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to actually define how the value is obtained. "extracting header list values" shouldn't be used for new features.
And similarly to Content-Type
we probably want to minimize the information that is exchanged through some sort of safelisting.
@annevk Thanks for reviewing. I'm new to this area so I wanna ask you something.
Do you means that this change require "extract Content Encoding" algorithm like "extract a MIME type" ?
I think it should be seems like restricted to well-known codings like
is that right ? or is there some lists which I should refer to ? |
Yeah, extract a MIME type is an example of modern-style header parsing. I think all things written in terms of https://fetch.spec.whatwg.org/#concept-header-list-get or https://fetch.spec.whatwg.org/#concept-header-list-get-decode-split are good examples. There is a registry for content codings here: https://www.iana.org/assignments/http-parameters/http-parameters.xhtml#content-coding. I'm not sure if we have to acknowledge all of them however. |
See also #716. |
We should also include |
@annevk Thanks, I'll be digging them. @yoavweiss in this case, should new encodings be added to the IANA list first ? |
These changes are to support addition of content type attribute to Perfomance resource timing. Further details are available at
w3c/resource-timing#381
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff