Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trueberryless contributor list #33

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Nov 10, 2024

Adds truberry's contributor list to the main page. (Was just testing this out to see what it would look like.)

@trueberryless - Since we have an Astro Docs implementation, we may end up using that in the end eventually, but I wanted to make a PR to test here!

Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for contribute-docs-astro-build ready!

Name Link
🔨 Latest commit 16338e6
🔍 Latest deploy log https://app.netlify.com/sites/contribute-docs-astro-build/deploys/6730d662ac830c0008539a30
😎 Deploy Preview https://deploy-preview-33--contribute-docs-astro-build.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918
Copy link
Member Author

Care to come leave a review, @trueberryless-org ??

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall!

But what are these files in the .cache folder?
I recently played around with deno 2.0 and saw these files, but I think I didn't include any deno stuff in my contributor list. Did you @sarah11918 use deno locally?

Postscript (PS): Please ping me with @trueberryless otherwise I won't get notified (I saw this by pure coincidence...)

@sarah11918
Copy link
Member Author

sarah11918 commented Nov 11, 2024

Hey @trueberryless ! I did not use deno? 😅 I figured that the cache is because there are images now? Also, I don't know whether working in IDX does anything weird. I'll ask @delucis to take a look, but he is very busy with other things!

I mostly wanted to make a PR to see what it would look like. And, I'm marking this draft for now as we may use our own implementation eventually!

@sarah11918 sarah11918 marked this pull request as draft November 11, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants