refactor(core): extract custom state feature #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new custom pseudo state feature - move `custom-states` & `state-validators` to custom-state helper file
idoros
added
core
- changed `StylableDirectives` to `StPartDirectives` and moved to css class feature - remove `features/types.ts` - finally removed `stylable-value-parsers`
- new `css-pseudo-class` feature - moved transform code to new feature - piggyback `scopeSelectorAst` on `ScopeContext` to keep refactor small
- re-write tests to new inline expectation format - expose diagnostics messages internally for tests - remove unused `core-test-kit` matchers
idoros
force-pushed
the
ido/extract-custom-psuedo-state-feature
branch
from
b659763
to
91655e6
Compare
barak007
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts more of the core analyze/transform flow into feature code as a preparation for future work for mapped state with parameter and standalone state definitions. Specifically focusing on the custom pseudo state and some of the features around it, like
css-pseudo-class&css-class.Tasks
st-custom-statefeaturecss-pseudo-classfeaturecss-classfeature (ideally this should be further separated into a futurest-partfeature).