k8s: Remove Argo managed services from helmfile #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit seeks to remove services that are now fully migrated to argo from the main helmfile.yaml. This should prevent running `make apply` from showing phantom diffs where argo has already enacted the change but helm hasn't yet recorded that change in its secrets.
tarrow
force-pushed
the
helmfileForArgo
branch
from
77b8722
to
725a1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit seeks to remove services that are now fully migrated to argo from the main helmfile.yaml.
This should prevent running
make applyfrom showing phantom diffs where argo has already enacted the change but helm hasn't yet recorded that change in its secrets.The github actions reference
generate-valuesand not the specific helmfile yaml so this patch should not require any updates to either check-generated-values or the image bumping scripts from api or ui.