Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Remove constexpr mutex define on Windows #7375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Nov 10, 2024

Since we ship a newer runtime, and we also have checks to ensure a valid runtime, we can remove this for the last time.

@Gold856 Gold856 marked this pull request as ready for review November 10, 2024 08:36
@Gold856 Gold856 requested a review from a team as a code owner November 10, 2024 08:36
@Gold856
Copy link
Contributor Author

Gold856 commented Nov 10, 2024

I used the artifacts from this PR and loaded it in a robot project. I have this in the constructor:

  public Robot() {
    System.out.println(WPILibVersion.Version);
    new TalonFX(0);
  }

I get our custom error when VS Code isn't configured to point to our JDK:
image
When I add

  "java.configuration.runtimes": [
    {
      "name": "JavaSE-17",
      "path": "C:\\Users\\Public\\wpilib\\2025\\jdk"
    }
  ]

to my VS Code config, my robot project starts up normally.
image
The alpha tag is because my fork doesn't have all the tags the main repo does.
WPILib Information:
Project Version: 2025.1.1-beta-1
VS Code Version: 1.94.2
WPILib Extension Version: 2025.1.1-beta-1
C++ Extension Version: 1.22.9
Java Extension Version: 1.36.2024092708
Java Debug Extension Version: 0.58.2024090204
Java Dependencies Extension Version 0.24.0
Java Version: 17
Java Location: C:\Users\Public\wpilib\2025\jdk
Vendor Libraries:
CTRE-Phoenix (v6) (25.0.0-beta-2)
photonlib (v2025.0.0-beta-1)
REVLib (2025.0.0-beta-1)
WPILib-New-Commands (1.0.0)

@Gold856 Gold856 changed the title [build] Remove constexpr mutex define [build] Remove constexpr mutex define on Windows Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants