better support working with Windows releases of libzmq #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inherit Py_WIN_VER by default unless specified in extra macros need to always load pyversion_compat for this to work
we don't have source control over libzmq itself to add includes
setting the minimum Windows version explicitly should allow us to pick up the latest compilers let's find out!
minrk
force-pushed
the
better-external-libzmq
branch
from
a8f2a0a
to
94954d4
Compare
- detect libzmq name with libzmq_name*.dll (matches libzmq-v140-mt-...dll) - include zmq-prefix in search path (Windows releases have single include+lib directory) - remove our own libzmq-dll-bundling support (rely on delvewheel to bundle non-extension libzmq) - add vcruntime-redist to %PATH% - fetch_libzmq --dll fetches Windows dll release
minrk
force-pushed
the
better-external-libzmq
branch
from
94954d4
to
7757796
Compare
use bundled libzmq for pypy since delvewheel doesn't seem to work for the pypy build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include/libsubdirs(Windows releases have singleflat include+lib directory)
non-extension libzmq)
instead of as an Extension.
This means Windows wheels will have libsodium instead of tweetnacl
closes #1476
closes #1475