Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [SVLS-5973] fix span pointer flow control #538

Conversation

apiarian-datadog
Copy link
Contributor

What does this PR do?

We are refactoring the dd-trace-py span pointer code to use Optional[...] returns instead of raise Exception(...) for flow control in DataDog/dd-trace-py#11353 . We are also switching all of the logged warnings that our customers cannot directly fix to debug.

Motivation

This needs to be merged and released before the dd-trace-py change is released.

Testing Guidelines

Unit and integration tests. Will also check in a live lambda setup.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@apiarian-datadog
Copy link
Contributor Author

tested this by the test lambda rig with both the new tracer code and the old. works as expected.

@apiarian-datadog apiarian-datadog marked this pull request as ready for review November 14, 2024 17:40
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner November 14, 2024 17:40
Copy link
Contributor

@nhulston nhulston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apiarian-datadog apiarian-datadog merged commit 7d16e8a into main Nov 14, 2024
51 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/svls-5973-handle-span-pointer-optional-flow-control branch November 14, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants