Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(botocore): [SVLS-5973] less noisy span pointers #11353

Merged
merged 15 commits into from
Nov 15, 2024

Conversation

apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Nov 11, 2024

Span pointer issues should be debug messages rather than warnings since they are not really actionable from the perspective of our users.

We'd also like to have some instrumentation telemetry to see how the logic is doing.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Nov 11, 2024

CODEOWNERS have been resolved as:

ddtrace/_trace/telemetry.py                                             @DataDog/apm-sdk-api-python
ddtrace/_trace/utils_botocore/span_pointers/telemetry.py                @DataDog/apm-sdk-api-python
releasenotes/notes/reduce-span-pointer-noise-e1cf01ec581a409c.yaml      @DataDog/apm-python
tests/tracer/test_telemetry.py                                          @DataDog/apm-sdk-api-python
ddtrace/_trace/_span_pointer.py                                         @DataDog/apm-sdk-api-python
ddtrace/_trace/utils_botocore/span_pointers/__init__.py                 @DataDog/apm-sdk-api-python
ddtrace/_trace/utils_botocore/span_pointers/dynamodb.py                 @DataDog/apm-sdk-api-python
ddtrace/_trace/utils_botocore/span_pointers/s3.py                       @DataDog/apm-sdk-api-python
tests/tracer/utils_botocore/test_span_pointers.py                       @DataDog/apm-sdk-api-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 11, 2024

Datadog Report

Branch report: aleksandr.pasechnik/less-noisy-span-pointers
Commit report: c467f9d
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 17m 54.7s Total duration (18m 47.2s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2024

Benchmarks

Benchmark execution time: 2024-11-15 18:21:25

Comparing candidate commit 9d668a7 in PR branch aleksandr.pasechnik/less-noisy-span-pointers with baseline commit 1aaed62 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 384 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟥 execution_time [+324.258ns; +376.425ns] or [+9.697%; +11.258%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+458.976ns; +525.694ns] or [+8.766%; +10.040%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+569.821ns; +636.564ns] or [+14.497%; +16.195%]

scenario:iast_aspects-replace_aspect

  • 🟥 execution_time [+499.671ns; +565.841ns] or [+7.077%; +8.015%]

@apiarian-datadog apiarian-datadog added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 12, 2024
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/less-noisy-span-pointers branch 2 times, most recently from 06d97dd to 6b8069d Compare November 12, 2024 22:00
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/less-noisy-span-pointers branch 2 times, most recently from 1956862 to 811774c Compare November 13, 2024 22:33
@apiarian-datadog
Copy link
Contributor Author

We also need to update telemetry, right? https://github.com/DataDog/dd-go/pull/158095

@apiarian-datadog
Copy link
Contributor Author

We also need to release DataDog/datadog-lambda-python#538 before we release this change.

@apiarian-datadog apiarian-datadog marked this pull request as ready for review November 14, 2024 17:55
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner November 14, 2024 17:55
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/less-noisy-span-pointers branch from 811774c to c467f9d Compare November 14, 2024 20:16
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/less-noisy-span-pointers branch from c467f9d to 9d668a7 Compare November 15, 2024 17:40
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner November 15, 2024 17:40
@apiarian-datadog apiarian-datadog added backport 2.16 backport 2.17 and removed changelog/no-changelog A changelog entry is not required for this PR. labels Nov 15, 2024
@apiarian-datadog apiarian-datadog changed the title chore: [SVLS-5973] less noisy span pointers fix(botocore): [SVLS-5973] less noisy span pointers Nov 15, 2024
@apiarian-datadog apiarian-datadog merged commit ecd0ab1 into main Nov 15, 2024
619 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/less-noisy-span-pointers branch November 15, 2024 18:24
github-actions bot pushed a commit that referenced this pull request Nov 15, 2024
Span pointer issues should be debug messages rather than warnings since
they are not really actionable from the perspective of our users.

We'd also like to have some instrumentation telemetry to see how the
logic is doing.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit ecd0ab1)
github-actions bot pushed a commit that referenced this pull request Nov 15, 2024
Span pointer issues should be debug messages rather than warnings since
they are not really actionable from the perspective of our users.

We'd also like to have some instrumentation telemetry to see how the
logic is doing.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit ecd0ab1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants