-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(botocore): [SVLS-5973] less noisy span pointers #11353
fix(botocore): [SVLS-5973] less noisy span pointers #11353
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 592 Passed, 694 Skipped, 17m 54.7s Total duration (18m 47.2s time saved) |
BenchmarksBenchmark execution time: 2024-11-15 18:21:25 Comparing candidate commit 9d668a7 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 384 metrics, 2 unstable metrics. scenario:iast_aspects-ospathbasename_aspect
scenario:iast_aspects-ospathjoin_aspect
scenario:iast_aspects-ospathsplit_aspect
scenario:iast_aspects-replace_aspect
|
06d97dd
to
6b8069d
Compare
1956862
to
811774c
Compare
We also need to update telemetry, right? https://github.com/DataDog/dd-go/pull/158095 |
We also need to release DataDog/datadog-lambda-python#538 before we release this change. |
811774c
to
c467f9d
Compare
c467f9d
to
9d668a7
Compare
Span pointer issues should be debug messages rather than warnings since they are not really actionable from the perspective of our users. We'd also like to have some instrumentation telemetry to see how the logic is doing. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit ecd0ab1)
Span pointer issues should be debug messages rather than warnings since they are not really actionable from the perspective of our users. We'd also like to have some instrumentation telemetry to see how the logic is doing. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit ecd0ab1)
Span pointer issues should be debug messages rather than warnings since they are not really actionable from the perspective of our users.
We'd also like to have some instrumentation telemetry to see how the logic is doing.
Checklist
Reviewer Checklist