Skip 'bad date' check for some imports #92
+304
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushing an empty pack should be fine. There was an earlier issue where deleting refs didn't work because we tried looking for objects in the uploaded pack and didn't find any. So we do want to preserve that functionality. We also should be able to accept new refs that point to commits that are already on the server. missing objects are actually bad, so we don't need to have pushes work when a partial graph is supplied. For now, the push still appears to succeed, but in the next step it won't.
We have this enabled in our prod config, and it changes spokes-receive-pack in important ways. In particular, it makes spokes-receive-pack care about bad dates, which we want to disable sometimes. So let's enable it here (and update the existing tests to match the new behavior.
… requested In general, it's better if customers rewrite their repos to remove the bad dates because bad dates aren't guaranteed to work with all of our systems and APIs. But, sometimes there are bad dates in a corner of a repo where they're unlikely to cause problems, and the cost of rewriting the repo is too high to be worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, we do not want malformed data on our servers. However, there are some corner cases where we do accept it. A bad date format in an old commit message is one such place. Again, in general, we won't accept pushes with bad dates. The correct fix is for the user to rewrite the offending commit(s) so that Git can parse all of the dates. Failing to do so will result in errors in many applications (including GitHub), so it's better to avoid pushing malformed data. However, some repos (particularly those that are migrating to GitHub) have deep history and a malformed bit of data far enough back that it is very unlikely to cause issues. In those cases, we do sometimes decide that that cost of a complete history rewrite isn't worth it, and we allow the import to proceed.
cc @dpmex4527 @ttaylorr @mhagger https://github.com/github/git-systems/issues/3882