Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip 'bad date' check for some imports #92

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    20bb13d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Refactor TestMissingObjects

    spraints committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1b02164 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Split TestMissingObjects

    Pushing an empty pack should be fine. There was an earlier issue where
    deleting refs didn't work because we tried looking for objects in the
    uploaded pack and didn't find any. So we do want to preserve that
    functionality. We also should be able to accept new refs that point to
    commits that are already on the server.
    
    missing objects are actually bad, so we don't need to have pushes work
    when a partial graph is supplied. For now, the push still appears to
    succeed, but in the next step it won't.
    spraints committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c428812 View commit details
    Browse the repository at this point in the history
  2. Enable receive.fsckObjects in tests

    We have this enabled in our prod config, and it changes
    spokes-receive-pack in important ways. In particular, it makes
    spokes-receive-pack care about bad dates, which we want to disable
    sometimes. So let's enable it here (and update the existing tests to
    match the new behavior.
    spraints committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    adecdda View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Allow bad dates, but only for imports and only when it's specifically…

    … requested
    
    In general, it's better if customers rewrite their repos to remove the
    bad dates because bad dates aren't guaranteed to work with all of our
    systems and APIs. But, sometimes there are bad dates in a corner of a
    repo where they're unlikely to cause problems, and the cost of rewriting
    the repo is too high to be worth it.
    spraints committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f581645 View commit details
    Browse the repository at this point in the history