[WIP] OCPBUGS-32250: Prevent UniqueHost from stopping plugin chain #574
Conversation
openshift-ci-robot
added
the
jira/severity-important
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/valid-reference
|
@gcs278: This pull request references Jira Issue OCPBUGS-32250, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gcs278
changed the title
gcs278
force-pushed
the
router-resync-fix
branch
from
3bdd1fb
to
cb444e6
Compare
gcs278
force-pushed
the
router-resync-fix
branch
from
cb444e6
to
126af48
Compare
Remove the ResourceVersion check in the UniqueHost Plugin to ensure it "activates" routes even when there are no changes. If routes aren't "activated", the UniqueHost Plugin won't call downstream plugins. If the downstream plugins aren't called, then the route status won't have a chance to resync. Resyncing route status is vital for after periods of status contention, which can occur when rolling out new versions of the router. If the new router loses the status update battle to the old router and the old router is subsequently terminated, the new router needs to resync the status to achieve the right state. Removing this ResourceVersion check should only impact resyncs, as routes are only reconciled without changes during resyncs, except at initial startup.
gcs278
force-pushed
the
router-resync-fix
branch
from
126af48
to
2370e29
Compare
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@gcs278: This pull request references Jira Issue OCPBUGS-32250, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@lihongan: This pull request references Jira Issue OCPBUGS-32250, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/test e2e-metal-ipi-ovn-ipv6 |
|
@gcs278: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
openshift-ci
bot
removed
the
lifecycle/stale
Fix UniqueHost so that it doesn't completely stop the plugin chain if the route is not "activated" because the the ResourceVersion on the route didn't change. This is a problem for resyncs as the ResourceVersion doesn't change, but the plugin change should continue.
WIP because I need to test more, and possibly develop E2Es to reproduce this scenario.