Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] OCPBUGS-32250: Prevent UniqueHost from stopping plugin chain #574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] OCPBUGS-32250: Prevent UniqueHost from stopping plugin chain #574

wants to merge 1 commit into from

Commits on Jun 13, 2024

  1. OCPBUGS-32250: Fix UniqueHost from Preventing Status Updates on Resyncs 

    Remove the ResourceVersion check in the UniqueHost Plugin to ensure it
"activates" routes even when there are no changes. If routes aren't
"activated", the UniqueHost Plugin won't call downstream plugins.
If the downstream plugins aren't called, then the route status won't
have a chance to resync.

Resyncing route status is vital for after periods of status contention,
which can occur when rolling out new versions of the router. If the
new router loses the status update battle to the old router and the old
router is subsequently terminated, the new router needs to resync the
status to achieve the right state.

Removing this ResourceVersion check should only impact resyncs, as
routes are only reconciled without changes during resyncs, except at
initial startup.
    @gcs278
    gcs278 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    2370e29 View commit details
    Browse the repository at this point in the history