chore: salesforce refactor

src/v0/destinations/salesforce/config.js

@@ -27,6 +27,8 @@ const DESTINATION = 'Salesforce';
 const SALESFORCE_OAUTH_SANDBOX = 'salesforce_oauth_sandbox';
 const OAUTH = 'oauth';
 const LEGACY = 'legacy';
+const SALESFORCE_OAUTH = 'salesforce_oauth';
+const SALESFORCE = 'salesforce';
 
 const mappingConfig = getMappingConfig(ConfigCategory, __dirname);
 
@@ -42,5 +44,7 @@ module.exports = {
   DESTINATION,
   OAUTH,
   LEGACY,
+  SALESFORCE_OAUTH,
   SALESFORCE_OAUTH_SANDBOX,
+  SALESFORCE,
 };

src/v0/destinations/salesforce/networkHandler.js

@@ -1,18 +1,22 @@
 const { proxyRequest, prepareProxyRequest } = require('../../../adapters/network');
 const { processAxiosResponse } = require('../../../adapters/utils/networkUtils');
-const { LEGACY } = require('./config');
-const { salesforceResponseHandler } = require('./utils');
+const { isHttpStatusSuccess } = require('../../util');
+const { SALESFORCE } = require('./config');
+// const { salesforceResponseHandler } = require('./utils');
+const { default: salesforceRegistry } = require('../../util/salesforce/registry');
 
 const responseHandler = (responseParams) => {
   const { destinationResponse, destType, rudderJobMetadata } = responseParams;
   const message = `Request for destination: ${destType} Processed Successfully`;
+  const { status } = destinationResponse;
 
-  salesforceResponseHandler(
-    destinationResponse,
-    'during Salesforce Response Handling',
-    rudderJobMetadata?.destInfo?.authKey,
-    LEGACY,
-  );
+  if (!isHttpStatusSuccess(status) && status >= 400) {
+    salesforceRegistry[SALESFORCE].responseHandler(
+      destinationResponse,
+      'during Salesforce Response Handling',
+      rudderJobMetadata?.destInfo?.authKey,
+    );
+  }
 
   // else successfully return status as 200, message and original destination response
   return {

src/v0/destinations/salesforce/transform.js

@@ -27,9 +27,9 @@
   generateErrorObject,
   isHttpStatusSuccess,
 } = require('../../util');
-const { salesforceResponseHandler, collectAuthorizationInfo, getAuthHeader } = require('./utils');
 const { handleHttpRequest } = require('../../../adapters/network');
 const { JSON_MIME_TYPE } = require('../../util/constant');
+const { default: salesforceRegistry } = require('../../util/salesforce/registry');
 
 // Basic response builder
 // We pass the parameterMap with any processing-specific key-value pre-populated
@@ -92,7 +92,7 @@
   response.method = defaultPostRequestConfig.requestMethod;
   response.headers = {
     'Content-Type': JSON_MIME_TYPE,
-    ...getAuthHeader({ authorizationFlow, authorizationData }),
+    ...salesforceRegistry[authorizationFlow].getAuthHeader(authorizationData),
   };
   response.body.JSON = removeUndefinedValues(rawPayload);
   response.endpoint = targetEndpoint;
@@ -114,7 +114,7 @@
     'get',
     objSearchUrl,
     {
-      headers: getAuthHeader({ authorizationFlow, authorizationData }),
+      headers: salesforceRegistry[authorizationFlow].getAuthHeader(authorizationData),
     },
     {
       metadata,
@@ -126,11 +126,10 @@
     },
   );
   if (!isHttpStatusSuccess(processedsfSearchResponse.status)) {
-    salesforceResponseHandler(
+    salesforceRegistry[authorizationFlow].responseHandler(
       processedsfSearchResponse,
       `:- SALESFORCE SEARCH BY ID`,
       destination.ID,
-      authorizationFlow,
     );
   }
   const searchRecord = processedsfSearchResponse.response?.searchRecords?.find(
@@ -234,7 +233,7 @@
       'get',
       leadQueryUrl,
       {
-        headers: getAuthHeader({ authorizationFlow, authorizationData }),
+        headers: salesforceRegistry[authorizationFlow].getAuthHeader(authorizationData),
       },
       {
         metadata,
@@ -247,11 +246,10 @@
     );
 
     if (!isHttpStatusSuccess(processedLeadQueryResponse.status)) {
-      salesforceResponseHandler(
+      salesforceRegistry[authorizationFlow].responseHandler(
         processedLeadQueryResponse,
         `:- during Lead Query`,
         destination.ID,
-        authorizationFlow,
       );
     }
 
@@ -359,7 +357,7 @@
 }
 
 async function process(event) {
-  const authInfo = await collectAuthorizationInfo(event);
+  const authInfo = await salesforceRegistry.getAuthInfo(event);
   const response = await processSingleMessage(
     event,
     authInfo.authorizationData,
@@ -371,7 +369,7 @@
 const processRouterDest = async (inputs, reqMetadata) => {
   let authInfo;
   try {
-    authInfo = await collectAuthorizationInfo(inputs[0]);
+    authInfo = await salesforceRegistry.getAuthInfo(inputs[0]);
   } catch (error) {
     const errObj = generateErrorObject(error);
     const respEvents = getErrorRespEvents(

src/v0/destinations/salesforce_oauth/networkHandler.js

@@ -1,18 +1,20 @@
 const { proxyRequest, prepareProxyRequest } = require('../../../adapters/network');
 const { processAxiosResponse } = require('../../../adapters/utils/networkUtils');
-const { OAUTH } = require('../salesforce/config');
-const { salesforceResponseHandler } = require('../salesforce/utils');
+const { isHttpStatusSuccess } = require('../../util');
+const { SALESFORCE_OAUTH } = require('../salesforce/config');
+const { default: salesforceRegistry } = require('../../util/salesforce/registry');
 
 const responseHandler = (responseParams) => {
-  const { destinationResponse, destType, rudderJobMetadata } = responseParams;
+  const { destinationResponse, destType } = responseParams;
   const message = `Request for destination: ${destType} Processed Successfully`;
+  const { status } = destinationResponse;
 
-  salesforceResponseHandler(
-    destinationResponse,
-    'during Salesforce Response Handling',
-    rudderJobMetadata?.destInfo?.authKey,
-    OAUTH,
-  );
+  if (!isHttpStatusSuccess(status) && status >= 400) {
+    salesforceRegistry[SALESFORCE_OAUTH].responseHandler(
+      destinationResponse,
+      'during Salesforce Response Handling',
+    );
+  }
 
   // else successfully return status as 200, message and original destination response
   return {

src/v0/destinations/salesforce_oauth_sandbox/networkHandler.js

@@ -1,17 +1,16 @@
 const { proxyRequest, prepareProxyRequest } = require('../../../adapters/network');
 const { processAxiosResponse } = require('../../../adapters/utils/networkUtils');
-const { OAUTH } = require('../salesforce/config');
-const { salesforceResponseHandler } = require('../salesforce/utils');
+const { SALESFORCE_OAUTH_SANDBOX } = require('../salesforce/config');
+const { default: salesforceRegistry } = require('../../util/salesforce/registry');
 
 const responseHandler = (responseParams) => {
   const { destinationResponse, destType, rudderJobMetadata } = responseParams;
   const message = `Request for destination: ${destType} Processed Successfully`;
 
-  salesforceResponseHandler(
+  salesforceRegistry[SALESFORCE_OAUTH_SANDBOX].responseHandler(
     destinationResponse,
     'during Salesforce Response Handling',
     rudderJobMetadata?.destInfo?.authKey,
-    OAUTH,
   );
 
   // else successfully return status as 200, message and original destination response